Plugin install error: TypeError: self.onAction is not a function

[Duft Markus]

Hey,

On current master with our plugins I'm getting "Plugin install error: TypeError: self.onAction is not a function" whenever loading any page in PolyGerrit. I tried to figure out which plugin causes the issue, but I'm unable to find any logs. Also the dev console is not very helpful:

HTTP 200 GET 64ms /changes/?O=881&S=0&q=is%3Aope..................[snip]
gr-app.js:1466 Plugin install error: TypeError: self.onAction is not a function
gr-app.js:1452 .panel() is deprecated! Use registerCustomComponent() instead.
Plugin.panel @ gr-app.js:1452
gr-app.js:1467 Plugin lfs installed.
gr-app.js:1467 Plugin ssi_logo-1 installed.
gr-app.js:1370 pageLoaded should be called after window.onload
pageLoaded @ gr-app.js:1370
gr-app.js:1368 App Started: 783

I suspect that it is a plugin which wants to contribute something to the UI, which in my case would be (only plugins not in core):

avatars-gravatar
delete-project
gitiles
lfs


Is there a place where I can find more information, or, even better, can I somehow change the log message to include the offending plugin name? I'm building from source anyway :)

Cheers,
Markus

--
Mit freundlichen GrÌßen / Best regards

Markus Duft | Software Architect
SSI SCHÄFER | SSI SchÀfer IT Solutions GmbH | Friesachstraße 15 | 8114 Friesach bei Graz | Austria
Phone [phone] | Fax [phone]
***@ssi-schaefer.com<mailto:***@ssi-schaefer.com>
Website<http://www.salomon.at/> | Blog<http://www.ssi-schaefer.de/blog/> | YouTube<http://www.youtube.com/user/lagerlogistik1> | Facebook<https://www.facebook.com/SSI.SCHAEFER.DE>


SSI SchÀfer IT Solutions GmbH | Friesachstrasse 15 | 8114 Friesach | Austria
Registered Office: Friesach | Commercial Register: 49324 K | VAT no. ATU28654300
Commercial Court: Landesgericht fÃŒr Zivilrechtssachen Graz

[David Pursehouse]

Hey,
TypeError: self.onAction is not a function” whenever loading any page in
PolyGerrit. I tried to figure out which plugin causes the issue, but I’m
HTTP 200 GET 64ms /changes/?O=881&S=0&q=is%3Aope





[snip]
gr-app.js:1466 Plugin install error: TypeError: self.onAction is not a function
gr-app.js:1452 .panel() is deprecated! Use registerCustomComponent() instead.
gr-app.js:1467 Plugin lfs installed.
gr-app.js:1467 Plugin ssi_logo-1 installed.
gr-app.js:1370 pageLoaded should be called after window.onload
gr-app.js:1368 App Started: 783
I suspect that it is a plugin which wants to contribute something to the
avatars-gravatar
delete-project
gitiles
lfs

Of those plugins, delete-project is the only one as far as I can see that
calls onAction:

delete-project $ git grep onAction
src/main/resources/static/delete-project.js: self.onAction('project',
'delete', onDeleteProject);

There's a change up for review that adds polygerrit support for this plugin:

https://gerrit-review.googlesource.com/c/plugins/delete-project/+/140591

I have not tried it myself...

Is there a place where I can find more information, or, even better, can I
somehow change the log message to include the offending plugin name? I’m
building from source anyway J
Cheers,
Markus
--
Mit freundlichen GrÌßen / Best regards
Markus Duft | Software Architect
SSI SCHÄFER | SSI SchÀfer IT Solutions GmbH | Friesachstraße 15 | 8114
<https://maps.google.com/?q=Friesachstra%C3%9Fe+15+%7C+8114&entry=gmail&source=g>
Friesach bei Graz | Austria
Phone [phone] <+43%203127%20200575> | Fax [phone]
Website <http://www.salomon.at/> | Blog <http://www.ssi-schaefer.de/blog/>
| YouTube <http://www.youtube.com/user/lagerlogistik1> | Facebook
<https://www.facebook.com/SSI.SCHAEFER.DE>
SSI SchÀfer IT Solutions GmbH | Friesachstrasse 15 | 8114
<https://maps.google.com/?q=Friesachstrasse+15+%7C+8114&entry=gmail&source=g>
Friesach | Austria
Registered Office: Friesach | Commercial Register: 49324 K | VAT no. ATU28654300
Commercial Court: Landesgericht fÃŒr Zivilrechtssachen Graz
--
--
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups
"Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an
For more options, visit https://groups.google.com/d/optout.

[Duft Markus]

Thanks for the info ☺

From: David Pursehouse [mailto:***@gmail.com]
Sent: Monday, June 11, 2018 10:27 AM
To: Duft Markus <***@ssi-schaefer.com>
Cc: Repo and Gerrit Discussion <repo-***@googlegroups.com>
Subject: Re: Plugin install error: TypeError: self.onAction is not a function

On Mon, Jun 11, 2018 at 5:07 PM Duft Markus <***@ssi-schaefer.com<mailto:***@ssi-schaefer.com>> wrote:
Hey,

On current master with our plugins I’m getting „Plugin install error: TypeError: self.onAction is not a function” whenever loading any page in PolyGerrit. I tried to figure out which plugin causes the issue, but I’m unable to find any logs. Also the dev console is not very helpful:

HTTP 200 GET 64ms /changes/?O=881&S=0&q=is%3Aope





[snip]
gr-app.js:1466 Plugin install error: TypeError: self.onAction is not a function
gr-app.js:1452 .panel() is deprecated! Use registerCustomComponent() instead.
Plugin.panel @ gr-app.js:1452
gr-app.js:1467 Plugin lfs installed.
gr-app.js:1467 Plugin ssi_logo-1 installed.
gr-app.js:1370 pageLoaded should be called after window.onload
pageLoaded @ gr-app.js:1370
gr-app.js:1368 App Started: 783

I suspect that it is a plugin which wants to contribute something to the UI, which in my case would be (only plugins not in core):

avatars-gravatar
delete-project
gitiles
lfs


Of those plugins, delete-project is the only one as far as I can see that calls onAction:

delete-project $ git grep onAction
src/main/resources/static/delete-project.js: self.onAction('project', 'delete', onDeleteProject);

There's a change up for review that adds polygerrit support for this plugin:

https://gerrit-review.googlesource.com/c/plugins/delete-project/+/140591

I have not tried it myself...



Is there a place where I can find more information, or, even better, can I somehow change the log message to include the offending plugin name? I’m building from source anyway ☺

Cheers,
Markus

--
Mit freundlichen GrÌßen / Best regards

Markus Duft | Software Architect
SSI SCHÄFER | SSI SchÀfer IT Solutions GmbH | Friesachstraße 15 | 8114<https://maps.google.com/?q=Friesachstra%C3%9Fe+15+%7C+8114&entry=gmail&source=g> Friesach bei Graz | Austria
Phone [phone]<tel:+43%203127%20200575> | Fax [phone]
***@ssi-schaefer.com<mailto:***@ssi-schaefer.com>
Website<http://www.salomon.at/> | Blog<http://www.ssi-schaefer.de/blog/> | YouTube<http://www.youtube.com/user/lagerlogistik1> | Facebook<https://www.facebook.com/SSI.SCHAEFER.DE>


SSI SchÀfer IT Solutions GmbH | Friesachstrasse 15 | 8114<https://maps.google.com/?q=Friesachstrasse+15+%7C+8114&entry=gmail&source=g> Friesach | Austria
Registered Office: Friesach | Commercial Register: 49324 K | VAT no. ATU28654300
Commercial Court: Landesgericht fÃŒr Zivilrechtssachen Graz
--
--
To unsubscribe, email repo-discuss+***@googlegroups.com<mailto:repo-discuss%***@googlegroups.com>
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+***@googlegroups.com<mailto:repo-discuss+***@googlegroups.com>.
For more options, visit https://groups.google.com/d/optout.

SSI SchÀfer IT Solutions GmbH | Friesachstrasse 15 | 8114 Friesach | Austria
Registered Office: Friesach | Commercial Register: 49324 K | VAT no. ATU28654300
Commercial Court: Landesgericht fÃŒr Zivilrechtssachen Graz