Discussion:
need the permission on refs/for/abc too to push a merge commit to refs/heads/abc directly?
Makson Lee
2018-12-05 04:56:31 UTC
Permalink
affected versions: 2.15.6, 2.16

we tried to push a merge commit to refs/heads/abc directly, but it is not
enough to grant 'push merge commit' permission on refs/heads/abc, we also
need to grant it on refs/for/abc, is this expected?
--
--
To unsubscribe, email repo-discuss+***@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
David Pursehouse
2018-12-05 06:32:23 UTC
Permalink
Post by Makson Lee
affected versions: 2.15.6, 2.16
we tried to push a merge commit to refs/heads/abc directly, but it is not
enough to grant 'push merge commit' permission on refs/heads/abc, we also
need to grant it on refs/for/abc, is this expected?
The "Push Merge" permission refers to pushing merges for review, and should
be granted on "refs/for/abc". It is not used to control direct push of
merges.

See the documentation here:
http://gerrit-documentation.storage.googleapis.com/Documentation/2.14/access-control.html#category_push_merge
Post by Makson Lee
--
--
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups
"Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an
For more options, visit https://groups.google.com/d/optout.
--
--
To unsubscribe, email repo-discuss+***@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
David Pursehouse
2018-12-05 06:34:40 UTC
Permalink
Post by David Pursehouse
Post by Makson Lee
affected versions: 2.15.6, 2.16
we tried to push a merge commit to refs/heads/abc directly, but it is not
enough to grant 'push merge commit' permission on refs/heads/abc, we also
need to grant it on refs/for/abc, is this expected?
The "Push Merge" permission refers to pushing merges for review, and
should be granted on "refs/for/abc". It is not used to control direct push
of merges.
Sorry, disregard that. I should have read the documentation more
thoroughly before replying.

Yes, it is necessary to also grant it on refs/for/abc.
Post by David Pursehouse
http://gerrit-documentation.storage.googleapis.com/Documentation/2.14/access-control.html#category_push_merge
Post by Makson Lee
--
--
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups
"Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an
For more options, visit https://groups.google.com/d/optout.
--
--
To unsubscribe, email repo-discuss+***@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Makson Lee
2018-12-05 06:59:34 UTC
Permalink
thanks, and according to the document, we only need the 'push merge commit'
permission on refs/for/abc.
Post by David Pursehouse
Post by David Pursehouse
Post by Makson Lee
affected versions: 2.15.6, 2.16
we tried to push a merge commit to refs/heads/abc directly, but it is
not enough to grant 'push merge commit' permission on refs/heads/abc, we
also need to grant it on refs/for/abc, is this expected?
The "Push Merge" permission refers to pushing merges for review, and
should be granted on "refs/for/abc". It is not used to control direct push
of merges.
Sorry, disregard that. I should have read the documentation more
thoroughly before replying.
Yes, it is necessary to also grant it on refs/for/abc.
Post by David Pursehouse
http://gerrit-documentation.storage.googleapis.com/Documentation/2.14/access-control.html#category_push_merge
Post by Makson Lee
--
--
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google
Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send
For more options, visit https://groups.google.com/d/optout.
--
--
To unsubscribe, email repo-discuss+***@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Loading...