verify-status-plugin and polyui

Discussion:

'Björn Pedersen' via Repo and Gerrit Discussion

2018-12-04 13:36:16 UTC

Hi,

we do use the verify status plugin (it builds and loads on 2.16 nicely),
but in polyui I get a js error as the gwt js is loaded in polyui context as
well:

verifystatus-0.js:1085 Tue Dec 04 14:25:36 GMT+100 2018 Class$134
SEVERE: TypeError: $wnd.Gerrit.get_raw is not a function
Class$S38: TypeError: $wnd.Gerrit.get_raw is not a function
at Unknown.Wc(verifystatus-0.js)
at Unknown.Tc(verifystatus-0.js)
at Unknown._b(verifystatus-0.js)
at Unknown.At(verifystatus-0.js)
at Unknown.g(verifystatus-0.js)
at Unknown.Wd(verifystatus-0.js)
at Unknown.Zd(verifystatus-0.js)
at Unknown.eval(verifystatus-0.js)
at Unknown.rt(verifystatus-0.js)
at Unknown.eval(verifystatus-0.js)
at Unknown.anonymous(<anonymous>)
at
Unknown.m(http://opc-158.office.frm2:8085/plugins/verify-status/static/verifystatus/verifystatus.nocache.js)
at
Unknown.anonymous(http://opc-158.office.frm2:8085/plugins/verify-status/static/verifystatus/verifystatus.nocache.js)
at
Unknown.l(http://opc-158.office.frm2:8085/plugins/verify-status/static/verifystatus/verifystatus.nocache.js)
at
Unknown.A.verifystatus.onScriptDownloaded(http://opc-158.office.frm2:8085/plugins/verify-status/static/verifystatus/verifystatus.nocache.js)
at
Unknown.anonymous(http://opc-158.office.frm2:8085/plugins/verify-status/static/verifystatus/8162A4E5098D95249A3B8192E56C872B.cache.js)

Any tips where look how to either suppress loading completly in polyui or
supply a polyui-compatible interface?

BjÃ¶rn

--
--
To unsubscribe, email repo-discuss+***@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

David Pursehouse

2018-12-04 14:24:39 UTC

Permalink

On Tue, Dec 4, 2018 at 10:36 PM 'BjÃ¶rn Pedersen' via Repo and Gerrit

Post by 'BjÃ¶rn Pedersen' via Repo and Gerrit Discussion
Hi,
we do use the verify status plugin (it builds and loads on 2.16 nicely),

Unrelated to your problem but note that this plugin has a quite outdated
master branch, i.e. there are a lot of commits on its stable-2.14 branch
that have not been merged up through stable-2.15 to master. I started
working on it but didn't have time to solve all the conflicts.

Post by 'BjÃ¶rn Pedersen' via Repo and Gerrit Discussion
but in polyui I get a js error as the gwt js is loaded in polyui context
verifystatus-0.js:1085 Tue Dec 04 14:25:36 GMT+100 2018 Class$134
SEVERE: TypeError: $wnd.Gerrit.get_raw is not a function
Class$S38: TypeError: $wnd.Gerrit.get_raw is not a function
at Unknown.Wc(verifystatus-0.js)
at Unknown.Tc(verifystatus-0.js)
at Unknown._b(verifystatus-0.js)
at Unknown.At(verifystatus-0.js)
at Unknown.g(verifystatus-0.js)
at Unknown.Wd(verifystatus-0.js)
at Unknown.Zd(verifystatus-0.js)
at Unknown.eval(verifystatus-0.js)
at Unknown.rt(verifystatus-0.js)
at Unknown.eval(verifystatus-0.js)
at Unknown.anonymous(<anonymous>)
at Unknown.m(
http://opc-158.office.frm2:8085/plugins/verify-status/static/verifystatus/verifystatus.nocache.js
)
at Unknown.anonymous(
http://opc-158.office.frm2:8085/plugins/verify-status/static/verifystatus/verifystatus.nocache.js
)
at Unknown.l(
http://opc-158.office.frm2:8085/plugins/verify-status/static/verifystatus/verifystatus.nocache.js
)
at Unknown.A.verifystatus.onScriptDownloaded(
http://opc-158.office.frm2:8085/plugins/verify-status/static/verifystatus/verifystatus.nocache.js
)
at Unknown.anonymous(
http://opc-158.office.frm2:8085/plugins/verify-status/static/verifystatus/8162A4E5098D95249A3B8192E56C872B.cache.js
)
Any tips where look how to either suppress loading completly in polyui or
supply a polyui-compatible interface?

You might be able to suppress it in the same way that the delete-project
plugin does, i.e. by enclosing everything in a conditional that is only
executed when it's not loaded in polygerrit:

https://gerrit.googlesource.com/plugins/delete-project/+/stable-2.16/src/main/resources/static/delete-project.js#15

Post by 'BjÃ¶rn Pedersen' via Repo and Gerrit Discussion
BjÃ¶rn
--
--
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups
"Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an
For more options, visit https://groups.google.com/d/optout.

'Björn Pedersen' via Repo and Gerrit Discussion

2018-12-05 07:42:08 UTC

Permalink

Post by David Pursehouse
On Tue, Dec 4, 2018 at 10:36 PM 'BjÃ¶rn Pedersen' via Repo and Gerrit

Post by 'BjÃ¶rn Pedersen' via Repo and Gerrit Discussion
Hi,
we do use the verify status plugin (it builds and loads on 2.16 nicely),

I'll try to push some changes.

Post by David Pursehouse

You might be able to suppress it in the same way that the delete-project
plugin does, i.e. by enclosing everything in a conditional that is only
https://gerrit.googlesource.com/plugins/delete-project/+/stable-2.16/src/main/resources/static/delete-project.js#15

Hmm, as there is no static js (only gwt generated things) I do not see
where I can hook into here. Shouldn't all GWT-generated code include this
by default?

BjÃ¶rn